[cmucl-commit] CMUCL commit: src/compiler (main.lisp)

[Raymond Toy]

    Date: Monday, March 28, 2011 @ 08:07:35
  Author: rtoy
    Path: /project/cmucl/cvsroot/src/compiler

Modified: main.lisp

Second return value of compile-file should be true if style-warnings
exist.

Issue noted by Douglas Crosher, cmucl-imp, 2011-03-23.


-----------+
 main.lisp |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)


Index: src/compiler/main.lisp
diff -u src/compiler/main.lisp:1.159 src/compiler/main.lisp:1.160
--- src/compiler/main.lisp:1.159	Fri Sep 24 08:12:05 2010
+++ src/compiler/main.lisp	Mon Mar 28 08:07:34 2011
@@ -5,7 +5,7 @@
 ;;; Carnegie Mellon University, and has been placed in the public domain.
 ;;;
 (ext:file-comment
-  "$Header: /project/cmucl/cvsroot/src/compiler/main.lisp,v 1.159 2010-09-24 12:12:05 rtoy Rel $")
+  "$Header: /project/cmucl/cvsroot/src/compiler/main.lisp,v 1.160 2011-03-28 12:07:34 rtoy Exp $")
 ;;;
 ;;; **********************************************************************
 ;;;
@@ -1907,8 +1907,12 @@
 		;; Hack around filesystem race condition...
 		(or (probe-file output-file-pathname) output-file-pathname)
 		nil)
-            (if (member error-severity '(:warning :error)) t nil)
-            ;; FIXME in the following we should not return t for a STYLE-WARNING
+	    ;; CLHS says the second return value "is false if no
+	    ;; conditions of type error or warning were detected by
+	    ;; the compiler".  This should include style-warnings.
+            (not (null error-severity))
+            ;; FIXME in the following we should not return t for a
+            ;; STYLE-WARNING
 	    (if (member error-severity '(:warning :error)) t nil))))
 
 ;;;; COMPILE and UNCOMPILE: